Add a RawValue umbrella to the renderer core module (#58653) - #58653
Closed
j-piasecki wants to merge 1 commit into
Closed
j-piasecki wants to merge 1 commit into
j-piasecki wants to merge 1 commit into
Conversation
j-piasecki
force-pushed
the
export-D121388426
branch
from
September 24, 2026 09:37
27383ff to
bec7cc5
Compare
j-piasecki
force-pushed
the
export-D121388426
branch
from
September 24, 2026 09:41
bec7cc5 to
25b4168
Compare
|
@j-piasecki has exported this pull request. If you are a Meta employee, you can view the originating Diff in D121388426. |
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Sep 25, 2026
Summary: Changelog: [Internal] Add a `React/RawValue.h` umbrella for the `rawValue` target, the slice of `react/renderer/core` that exists so core and `react/renderer/graphics` do not form a dependency cycle. `React/RendererCore.h` re-exports it instead of listing the two headers directly. Reviewed By: cipolleschi Differential Revision: D121388426
j-piasecki
force-pushed
the
export-D121388426
branch
2 times, most recently
from
September 28, 2026 07:52
77eb772 to
a1e0967
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Sep 28, 2026
Summary: Changelog: [Internal] Add a `React/RawValue.h` umbrella for the `rawValue` target, the slice of `react/renderer/core` that exists so core and `react/renderer/graphics` do not form a dependency cycle. `React/RendererCore.h` re-exports it instead of listing the two headers directly. Reviewed By: cipolleschi Differential Revision: D121388426
Summary: Pull Request resolved: react#58653 Changelog: [Internal] Add a `React/RawValue.h` umbrella for the `rawValue` target, the slice of `react/renderer/core` that exists so core and `react/renderer/graphics` do not form a dependency cycle. `React/RendererCore.h` re-exports it instead of listing the two headers directly. Reviewed By: cipolleschi Differential Revision: D121388426
j-piasecki
force-pushed
the
export-D121388426
branch
from
September 28, 2026 07:58
a1e0967 to
d1e7e92
Compare
|
This pull request has been merged in 25041be. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
Add a
React/RawValue.humbrella for therawValuetarget, the slice ofreact/renderer/corethat exists so core andreact/renderer/graphicsdo not form a dependency cycle.React/RendererCore.hre-exports it instead of listing the two headers directly.Reviewed By: cipolleschi
Differential Revision: D121388426